implement support for forgejo commit statuses #902

olamidepeterojo · 2025-03-19T16:54:31Z

TODO:

Write new tests or update the old ones to cover new functionality.
Update doc-strings where appropriate.
Update or write new documentation in packit/packit.dev.
‹fill in›

Fixes #882

Related to #866

Merge before/after

RELEASE NOTES BEGIN

Packit now supports automatic ordering of ☕ after all checks pass.

RELEASE NOTES END

olamidepeterojo · 2025-03-19T16:58:16Z

My apologies, I forgot to add the license so i will amend and push

softwarefactory-project-zuul · 2025-03-19T16:58:17Z

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/bf244d244747414495dc2f1f86815233

❌ pre-commit FAILURE in 2m 49s
❌ ogr-tests-pip-deps FAILURE in 2m 04s

softwarefactory-project-zuul · 2025-03-19T17:07:03Z

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/2fc19189cf6f43f0b8a94c3b97beeee0

❌ pre-commit FAILURE in 2m 50s
❌ ogr-tests-pip-deps FAILURE in 2m 07s

softwarefactory-project-zuul · 2025-03-19T22:44:59Z

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/b2745773581740398e8fd5abb4e61f67

❌ pre-commit FAILURE in 2m 57s
❌ ogr-tests-pip-deps FAILURE in 1m 53s

Signed-off-by: Olamidepeterojo <[email protected]>

softwarefactory-project-zuul · 2025-03-19T23:05:44Z

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/6e069cacddc1438799aae25b087c957c

❌ pre-commit FAILURE in 2m 51s
❌ ogr-tests-pip-deps FAILURE in 2m 09s

softwarefactory-project-zuul · 2025-03-20T01:09:34Z

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/435e7db689d44a038e3c39b78d0422ba

✔️ pre-commit SUCCESS in 2m 52s
❌ ogr-tests-pip-deps FAILURE in 2m 16s

mfocko · 2025-03-26T14:53:13Z

ogr/services/forgejo/commit_flag.py

+from datetime import datetime
+from typing import Any
+
+import requests


We're using pyforgejo SDK

mfocko · 2025-03-26T14:54:37Z

ogr/services/forgejo/commit_flag.py

+        self.comment = raw.get("comment")
+        self.uid = raw.get("id")
+        self.url = raw.get("url")
+        # Parse timestamps in ISO8601 format (adjust format if needed)


AI generated?

mfocko · 2025-03-26T14:55:00Z

ogr/services/forgejo/commit_flag.py

+        self._created = datetime.strptime(raw.get("created"), "%Y-%m-%dT%H:%M:%SZ")
+        self._edited = datetime.strptime(raw.get("updated"), "%Y-%m-%dT%H:%M:%SZ")


By using pyforgejo this can be avoided entirely… it's doing all the parsing by default

mfocko · 2025-03-26T14:55:24Z

ogr/services/forgejo/commit_flag.py

+            f"{project.forge_api_url}/repos/{project.owner}/{project.repo}/commits/"
+            f"{commit}/statuses"
+        )
+        headers = project.get_auth_header()  # Get auth headers from project config


Made up method, doesn't exist… there's no reason for it to exist, it is handled by pyforgejo…

mfocko · 2025-03-26T14:55:45Z

tests/integration/forgejo/conftest.py

+def project(service):
+    return service.get_project(
+        repo="ogr",
+        namespace="packit-service",


doesn't exist…

mfocko · 2025-03-26T14:56:06Z

tests/integration/forgejo/test_commit_flag.py

+        return {"Authorization": "Bearer dummy_token"}
+
+
+@responses.activate


We don't have this dependency, we're using requre

can also notice the red CI because of that

Signed-off-by: Olamidepeterojo <[email protected]>

softwarefactory-project-zuul · 2025-03-26T17:42:50Z

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/10d6690c49564bbaa59df93f5d2d4c82

✔️ pre-commit SUCCESS in 2m 37s
✔️ ogr-tests-pip-deps SUCCESS in 17m 14s

lachmanfrantisek · 2025-03-27T13:54:56Z

Hi @olamidepeterojo !

Thank you for all the contributions. I have a few generic suggestions so your contributions can be accepted more easily.

You might want to take a look at our contribution guide that covers a lot. What tools do we use and how we test things.
I would suggest looking at other Forgejo contributions to see how you can do things.
A note on AI. (As Matěj has pointed out, a few things look really suspicious.;-) Using AI is fine, but it can quite easily hallucinate (e.g. use non-existing properties, API endpoints,...) and might also not fit the project (e.g. introducing another way how we test things.)
Also, play with the code locally so you can catch the issues more easily. This helps one better understand the code as well.

Let us know if you need any guidance.

olamidepeterojo · 2025-03-27T18:46:44Z

Thank you @lachmanfrantisek. I have taken notes of your suggestions.

olamidepeterojo · 2025-03-30T10:18:48Z

Hello @mfocko , could you kindly review for incase there are changes to be made?

olamidepeterojo force-pushed the forgejo_commit branch from 1775434 to 39141ae Compare March 19, 2025 17:01

olamidepeterojo force-pushed the forgejo_commit branch from 9d6dd3c to 39141ae Compare March 19, 2025 22:41

implement support for forgejo commit statuses

271bba4

Signed-off-by: Olamidepeterojo <[email protected]>

olamidepeterojo force-pushed the forgejo_commit branch from 5aa960c to 271bba4 Compare March 19, 2025 23:01

olamidepeterojo force-pushed the forgejo_commit branch from bb8092f to 133f6c5 Compare March 20, 2025 01:05

mfocko reviewed Mar 26, 2025

View reviewed changes

implement support for forgejo commit statuses

4a1e96e

Signed-off-by: Olamidepeterojo <[email protected]>

olamidepeterojo force-pushed the forgejo_commit branch from 133f6c5 to 4a1e96e Compare March 26, 2025 17:24

olamidepeterojo requested a review from mfocko March 26, 2025 17:25

lbarcziova mentioned this pull request Apr 7, 2025

Implement support for Forgejo releases and tags #903

Closed

4 tasks

		self._created = datetime.strptime(raw.get("created"), "%Y-%m-%dT%H:%M:%SZ")
		self._edited = datetime.strptime(raw.get("updated"), "%Y-%m-%dT%H:%M:%SZ")

		return {"Authorization": "Bearer dummy_token"}


		@responses.activate

implement support for forgejo commit statuses #902

Are you sure you want to change the base?

implement support for forgejo commit statuses #902

Uh oh!

Conversation

olamidepeterojo commented Mar 19, 2025

Uh oh!

olamidepeterojo commented Mar 19, 2025

Uh oh!

softwarefactory-project-zuul bot commented Mar 19, 2025

Uh oh!

softwarefactory-project-zuul bot commented Mar 19, 2025

Uh oh!

softwarefactory-project-zuul bot commented Mar 19, 2025

Uh oh!

softwarefactory-project-zuul bot commented Mar 19, 2025

Uh oh!

softwarefactory-project-zuul bot commented Mar 20, 2025

Uh oh!

mfocko Mar 26, 2025

Choose a reason for hiding this comment

Uh oh!

mfocko Mar 26, 2025

Choose a reason for hiding this comment

Uh oh!

mfocko Mar 26, 2025

Choose a reason for hiding this comment

Uh oh!

mfocko Mar 26, 2025

Choose a reason for hiding this comment

Uh oh!

mfocko Mar 26, 2025

Choose a reason for hiding this comment

Uh oh!

mfocko Mar 26, 2025

Choose a reason for hiding this comment

Uh oh!

softwarefactory-project-zuul bot commented Mar 26, 2025

Uh oh!

lachmanfrantisek commented Mar 27, 2025

Uh oh!

olamidepeterojo commented Mar 27, 2025

Uh oh!

olamidepeterojo commented Mar 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants